Merge lp://qastaging/~lukas-kde/qtubuntu/wheelEvent into lp://qastaging/qtubuntu

Proposed by Lukáš Tinkl
Status: Merged
Approved by: Daniel d'Andrada
Approved revision: 278
Merged at revision: 282
Proposed branch: lp://qastaging/~lukas-kde/qtubuntu/wheelEvent
Merge into: lp://qastaging/qtubuntu
Diff against target: 66 lines (+37/-10)
1 file modified
src/ubuntumirclient/input.cpp (+37/-10)
To merge this branch: bzr merge lp://qastaging/~lukas-kde/qtubuntu/wheelEvent
Reviewer Review Type Date Requested Status
Daniel d'Andrada (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+273149@code.qastaging.launchpad.net

Commit message

Implement support for mouse wheel events

Description of the change

Implement support for mouse wheel events

Cf. https://bugs.launchpad.net/ubuntu/+source/qtmir/+bug/1497091

* Are there any related MPs required for this MP to build/function as expected? Please list.

https://code.launchpad.net/~lukas-kde/qtmir/wheelEvent/+merge/273150

* Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

* Did you make sure that your branch does not contain spurious tags?

Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Yes

* If you changed the UI, has there been a design review?

N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Daniel d'Andrada (dandrader) :
review: Approve
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

There's one little thing actually:

"""
+#include <QDebug>
"""

Please remove this leftover.

review: Needs Fixing
278. By Lukáš Tinkl

remove include QDebug

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> There's one little thing actually:
>
> """
> +#include <QDebug>
> """
>
> Please remove this leftover.

Fixed

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Daniel d'Andrada (dandrader) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches