Ubuntu Settings Components

Merge lp://qastaging/~lukas-kde/ubuntu-settings-components/extractPo into lp://qastaging/~registry/ubuntu-settings-components/trunk

  1. extractPo
  2. Merge into trunk
Proposed by Lukáš Tinkl
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 96
Merged at revision: 94
Proposed branch: lp://qastaging/~lukas-kde/ubuntu-settings-components/extractPo
Merge into: lp://qastaging/~registry/ubuntu-settings-components/trunk
Diff against target: 180 lines (+110/-5)
7 files modified
CMakeLists.txt (+1/-0)
plugins/Ubuntu/Settings/Components/QuickReply.qml (+1/-1)
plugins/Ubuntu/Settings/Menus/SnapDecisionMenu.qml (+3/-3)
plugins/Ubuntu/Settings/Menus/TextMessageMenu.qml (+1/-1)
po/CMakeLists.txt (+33/-0)
po/ubuntu-settings-components.pot (+35/-0)
po/update-usc-pot (+36/-0)
To merge this branch: bzr merge lp://qastaging/~lukas-kde/ubuntu-settings-components/extractPo
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Registry Administrators Pending
Review via email: mp+266669@code.qastaging.launchpad.net

Commit message

Setup message extraction, load the catalog from the plugins

Description of the change

Setup message extraction, load the catalog from the plugins

Until now, the user visible strings haven't been extracted and therefore couldn't be translated.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:94
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/118/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-vivid/43
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/25
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/25/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/118/rebuild

review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

I don't think we should include the Czech translation, should be done via https://translations.launchpad.net/ubuntu-settings-components once we commit this and configure that page correctly

review: Needs Fixing
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> I don't think we should include the Czech translation, should be done via
> https://translations.launchpad.net/ubuntu-settings-components once we commit
> this and configure that page correctly

Fair enough, yup. I'll adjust it

lp://qastaging/~lukas-kde/ubuntu-settings-components/extractPo updated
95. By Lukáš Tinkl

don't ship cs.po, rely on launchpad for the translations

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:95
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/119/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-vivid/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-amd64-ci/26
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/26
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/26/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/119/rebuild

review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Thinkign about this, i think this is not the correct solution, calling textdomain will overwrite the text domain set by the application that uses this plugin making its i18n() untranslated.

We should just use i18n.dtr() instead of i18n.tr()

review: Needs Fixing
lp://qastaging/~lukas-kde/ubuntu-settings-components/extractPo updated
96. By Lukáš Tinkl

use i18n.dtr() instead of overwriting the textdomain

Revision history for this message
Albert Astals Cid (aacid) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: