Merge lp://qastaging/~lukas-kde/unity8/launcherContextMenuKey into lp://qastaging/unity8
Proposed by
Lukáš Tinkl
| Status: | Merged |
|---|---|
| Approved by: | Michael Zanetti |
| Approved revision: | 2553 |
| Merged at revision: | 2585 |
| Proposed branch: | lp://qastaging/~lukas-kde/unity8/launcherContextMenuKey |
| Merge into: | lp://qastaging/unity8 |
| Diff against target: |
40 lines (+10/-2) 2 files modified
qml/Launcher/Launcher.qml (+1/-0) tests/qmltests/Launcher/tst_Launcher.qml (+9/-2) |
| To merge this branch: | bzr merge lp://qastaging/~lukas-kde/unity8/launcherContextMenuKey |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
| Michael Zanetti (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Open the quicklist (context) menu also using the Menu key
Description of the change
Open the quicklist (context) menu also using the Menu key
Fixes lp:1608265
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes, added a test
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A (catching up with u7)
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
looks good to me, works.
test change looks easy enough, ci should be ok (hasn't ran yet)