work-items-tracker

Merge lp://qastaging/~mabac/launchpad-work-items-tracker/linaro-roadmap-layout-fixes into lp://qastaging/~linaro-automation/launchpad-work-items-tracker/linaro

linaro-roadmap-layout-fixes
Merge into linaro

Proposed by Mattias Backman on 2011-11-30

Status:	Merged
Merged at revision:	308
Proposed branch:	lp://qastaging/~mabac/launchpad-work-items-tracker/linaro-roadmap-layout-fixes
Merge into:	lp://qastaging/~linaro-automation/launchpad-work-items-tracker/linaro
Diff against target:	44 lines (+8/-2) 2 files modified html-report (+6/-0) templates/roadmap_card.html (+2/-2)
To merge this branch:	bzr merge lp://qastaging/~mabac/launchpad-work-items-tracker/linaro-roadmap-layout-fixes
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Guilherme Salgado (community)		2011-11-30	Approve on 2011-11-30
Review via email: mp+83903@code.qastaging.launchpad.net

Description of the change

Hi,

Here's a leftover change that didn't get merged. It changes the roadmap card view to hide the blueprint table and progress bar when there are no linked blueprints.

Thanks,

Mattias

Revision history for this message

Guilherme Salgado (salgado) wrote on 2011-11-30:

Wow, it felt like I was reviewing PHP with all this code included within the html. ;)

I suppose blueprints.itervalues() would return a sequence of lists (or other sequences) and there's no way a None can end up there, right?

review: Needs Information

lp://qastaging/~mabac/launchpad-work-items-tracker/linaro-roadmap-layout-fixes updated on 2011-11-30

320. By Mattias Backman on 2011-11-30: Determine if card has blueprints outside of html template.

Revision history for this message

Mattias Backman (mabac) wrote on 2011-11-30:

On Wed, Nov 30, 2011 at 9:15 PM, Guilherme Salgado
<email address hidden> wrote:
> Review: Needs Information
>
> Wow, it felt like I was reviewing PHP with all this code included within the html. ;)

Hehe sorry about that. I'm not too happy with the results when trying
to do smart things in the templates. I have pushed an update to make
it a little less cluttered.

>
> I suppose blueprints.itervalues() would return a sequence of lists (or other sequences) and there's no way a None can end up there, right?

Famous last words: nope, that shouldn't happen. :) They're all
initialized to [] in report_tools.card_blueprints_by_status().

> --
> https://code.launchpad.net/~mabac/launchpad-work-items-tracker/linaro-roadmap-layout-fixes/+merge/83903
> You are the owner of lp:~mabac/launchpad-work-items-tracker/linaro-roadmap-layout-fixes.