work-items-tracker

Merge lp://qastaging/~mabac/launchpad-work-items-tracker/remove-html-extensions into lp://qastaging/~linaro-automation/launchpad-work-items-tracker/linaro

remove-html-extensions
Merge into linaro

Proposed by Mattias Backman on 2011-12-14

Status:	Rejected
Rejected by:	Mattias Backman on 2011-12-15
Proposed branch:	lp://qastaging/~mabac/launchpad-work-items-tracker/remove-html-extensions
Merge into:	lp://qastaging/~linaro-automation/launchpad-work-items-tracker/linaro
Diff against target:	74 lines (+7/-7) 3 files modified report_tools.py (+4/-4) templates/roadmap_card.html (+1/-1) templates/roadmap_lane.html (+2/-2)
To merge this branch:	bzr merge lp://qastaging/~mabac/launchpad-work-items-tracker/remove-html-extensions
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Linaro Infrastructure		2011-12-14	Pending
Review via email: mp+85744@code.qastaging.launchpad.net

Description of the change

Hi,

This branch removes the .html extension from the generated card and lane pages.

It also removes the leading blank line from the base.html template. The reason we need it is that IS has enabled some magic apache trick that will show pages without extensions if the content "looks like" html. That heuristic fails if there is a blank line before any tags.

Thanks,

Mattias

lp://qastaging/~mabac/launchpad-work-items-tracker/remove-html-extensions updated on 2011-12-15

317. By Mattias Backman on 2011-12-15: Revert removing the leading blank line.

Revision history for this message

Mattias Backman (mabac) wrote on 2011-12-15:

IS changed their solution so we don't need to remove the blank line anymore.

Revision history for this message

Guilherme Salgado (salgado) wrote on 2011-12-15:

I'm not sure I understand why we're doing this. Is this something we
wanted to do and now we can as they've changed apache to detect the
content-type of extensionless files?

Revision history for this message

Mattias Backman (mabac) wrote on 2011-12-15:

We need the changes that are left in the branch. That is generate the files without the .html extension. I reverted the other change.

Unmerged revisions

317. By Mattias Backman on 2011-12-15: Revert removing the leading blank line.
316. By Mattias Backman on 2011-12-14: Remove .html extension from lane and card reports.
315. By Mattias Backman on 2011-12-14: Remove leading blank line in the base.html template.