Merge lp://qastaging/~macslow/notify-osd/exit-if-being-replaced into lp://qastaging/notify-osd

Proposed by Mirco Müller
Status: Merged
Approved by: Michał Sawicz
Approved revision: 473
Merged at revision: 473
Proposed branch: lp://qastaging/~macslow/notify-osd/exit-if-being-replaced
Merge into: lp://qastaging/notify-osd
Prerequisite: lp://qastaging/~larsu/notify-osd/allow-being-replaced
Diff against target: 56 lines (+17/-1)
2 files modified
src/dbus.c (+4/-1)
src/main.c (+13/-0)
To merge this branch: bzr merge lp://qastaging/~macslow/notify-osd/exit-if-being-replaced
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+193121@code.qastaging.launchpad.net

Commit message

Watch "NameLost" signal on DBus and exit if received.

Description of the change

* fix crucial typo
* fix a small mem-leak
* make notify-osd watch "NameLost" DBus-signal and quit, if other process takes ownership of notification-service

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Yup, this is working!

review: Approve
Revision history for this message
Lars Karlitski (larsu) wrote :

Connecting gtk_main_quit() directly to the NameLost signal is a bit ugly but will definitely work.

Thanks for fixing this Mirco!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches