Merge lp://qastaging/~macslow/notify-osd/fix.810325 into lp://qastaging/notify-osd/oneiric
Proposed by
Mirco Müller
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~macslow/notify-osd/fix.810325 |
| Merge into: | lp://qastaging/notify-osd/oneiric |
| Diff against target: |
140 lines (+50/-8) 3 files modified
src/bubble.c (+13/-7) src/defaults.c (+36/-1) src/defaults.h (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~macslow/notify-osd/fix.810325 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Canonical Desktop Experience Team | Pending | ||
|
Review via email:
|
|||
Description of the change
The background-color for a bubble will be read from a GSettings key ("com.canonical
To ensure there's enough contrast between the bubble background and its contents only 75% of the read background-color is applied.
For this to work Unity with lp:~unity-team/unity/fix.810325 merged in has to be running.
To post a comment you must log in.
Revision history for this message
| Sebastien Bacher (seb128) wrote | # |
Unmerged revisions
- 445. By Mirco Müller
-
really make sure the average-color is read at startup
- 444. By Mirco Müller
-
apply only 75% of the average-color to keep enough contrast to the text and icon, pick up the average upon startup... not only on wallpaper-change
- 443. By Mirco Müller
-
trying to fix LP: #810325
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
One issue with that patch is that it makes notify-osd depends on unity by the way gsettings schemas are working (or you would need to do hacks to check if the unity schemas is installed and fallback to a default value if it's not). Wouldn't it make sense to add an unity dbus method to export the value and query the value over dbus? it would make easier to do handle non unity scenarios.
otherwise small comment, it seems your indentation is mixing tabs and space