Merge lp://qastaging/~macslow/unity/unity.fix-841945 into lp://qastaging/unity
| Status: | Merged |
|---|---|
| Approved by: | Neil J. Patel |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1513 |
| Proposed branch: | lp://qastaging/~macslow/unity/unity.fix-841945 |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
329 lines (+75/-49) 8 files modified
plugins/unityshell/resources/dash-widgets.json (+2/-2) plugins/unityshell/src/DashSearchBar.cpp (+2/-2) plugins/unityshell/src/DashStyle.cpp (+33/-28) plugins/unityshell/src/FilterExpanderLabel.cpp (+4/-2) plugins/unityshell/src/FilterGenreWidget.cpp (+13/-8) plugins/unityshell/src/FilterMultiRangeWidget.cpp (+10/-0) plugins/unityshell/src/FilterRatingsButton.cpp (+7/-4) plugins/unityshell/src/PlacesGroup.cpp (+4/-3) |
| To merge this branch: | bzr merge lp://qastaging/~macslow/unity/unity.fix-841945 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Neil J. Patel (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch fixes a lot of the issues stated in the mega-bug LP: #841945. But since it so much not everything is done yet. Still already done fixes should move into trunk as soon as possible. Here's a list of done fixes:
from the list of positioning issues:
- The Category Headers are positioned wrong (too far left, too low)
- The magnifying glass inside the search box is positioned wrong (should be further to the left)
- There is too much space below each category header
- "Filter results" header is positioned wrong (should be right and slightly up)
- The "All" button is aligned incorrectly relative to the other filter buttons (right sides should fall on the same vertical axis)
from the list of shape issues:
- "Filter results" is the wrong font size and weight
- The corner radius of the search filter toggle boxes is wrong
- The 'rating' stars are the wrong size
- the un-selected 'rating' star has the wrong border
- the 1px dividers in-between the categories should be narrower with 15px margin on each side
- the dividers in between the filter results categories are missing
- the 'All' button's shape is very wrong
- the filter results category headers are with wrong font size and weight
Here's a screenshot of the new looks http://
| Neil J. Patel (njpatel) | # |
