Merge lp://qastaging/~macslow/unity/unity.fix-844889 into lp://qastaging/unity

Proposed by Mirco Müller
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 1565
Proposed branch: lp://qastaging/~macslow/unity/unity.fix-844889
Merge into: lp://qastaging/unity
Diff against target: 172 lines (+32/-26)
8 files modified
plugins/unityshell/resources/dash-widgets.json (+1/-1)
plugins/unityshell/src/DashSearchBar.cpp (+1/-1)
plugins/unityshell/src/DashStyle.cpp (+1/-1)
plugins/unityshell/src/FilterExpanderLabel.cpp (+1/-0)
plugins/unityshell/src/LensBar.cpp (+21/-4)
plugins/unityshell/src/LensBarIcon.cpp (+5/-18)
plugins/unityshell/src/PlacesGroup.cpp (+1/-1)
plugins/unityshell/src/ResultRendererTile.cpp (+1/-0)
To merge this branch: bzr merge lp://qastaging/~macslow/unity/unity.fix-844889
Reviewer Review Type Date Requested Status
Gord Allott (community) Approve
Review via email: mp+75513@code.qastaging.launchpad.net

Description of the change

Fixed issues:

- Category header icons are too large
- The font size of category header titles is too larged
- The search result icons are too small
- The search filter toggle boxes are too high
- The search filter toggle boxes are too narrow
- the search box is too short
- The the font size of the text underneath each icon in the search results is too large
- The size and shape of the arrow that points to the currently selected Dash Lens is incorrect

See:
http://people.canonical.com/~mmueller/fix-844889-1.jpg

Issues that can't be fixed, because it would introduce some sort of regression or would otherwise cause breakage:
- The search box is positioned wrong (centre should align with the center of the BFB, should start a few px to the left)
- There is too much space between the individual icons in the search result
- There is too much space below each category header
- The desktop dash box is much too large (both height and width)
- the expand/collapse triangle is the wrong shape and size
- the expand/collapse triangle is missing from the filter results category headers

NOTE: We're still also waiting for an ACK regarding the UIFe from the documentation-team

To post a comment you must log in.
Revision history for this message
Gord Allott (gordallott) wrote :

worked well here

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.