Unity

Merge lp://qastaging/~macslow/unity/unity.fix-863240 into lp://qastaging/unity

  1. unity.fix-863240
  2. Merge into trunk
Proposed by Mirco Müller
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 1841
Proposed branch: lp://qastaging/~macslow/unity/unity.fix-863240
Merge into: lp://qastaging/unity
Diff against target: 126 lines (+46/-14)
2 files modified
plugins/unityshell/src/DashSearchBar.cpp (+40/-14)
plugins/unityshell/src/DashSearchBar.h (+6/-0)
To merge this branch: bzr merge lp://qastaging/~macslow/unity/unity.fix-863240
Reviewer Review Type Date Requested Status
Gord Allott (community) Approve
Andrea Cimitan (community) Abstain
Review via email: mp+88213@code.qastaging.launchpad.net

Description of the change

Fixes the position, alignment, spacing and arrow-artwork for the "Filter results". See...

http://people.canonical.com/~mmueller/fix-863240.png

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) wrote :

The arrow should be moved few pixels below... At least comparing your screenshot with https://launchpadlibrarian.net/81538790/file_lens_filters.png

review: Needs Fixing
Revision history for this message
Mirco Müller (macslow) wrote :

> The arrow should be moved few pixels below... At least comparing your
> screenshot with https://launchpadlibrarian.net/81538790/file_lens_filters.png

That's not possible with nux' layout right now.

Revision history for this message
Andrea Cimitan (cimi) wrote :

So we can merge it, but keep the bug opened (In progress) until it is fixed. Or we need workarounds... but we can't deliver all those imperfections in 12.04

Revision history for this message
Mirco Müller (macslow) wrote :

> So we can merge it, but keep the bug opened (In progress) until it is fixed.
> Or we need workarounds... but we can't deliver all those imperfections in
> 12.04

I fixed the position with an insane nested nux-layout solution just for the arrow... and got Jay to agree on my request for extending nux' layout API with an pixel-offset ability. But that's something which will not happen right away. So we can just use my current work-around for the position-fix.

Revision history for this message
Andrea Cimitan (cimi) wrote :

I am fine with the visual changes then, you should do the same for the "see more lines..." issue as well (definitely!!!).
On the code side, waiting for a unity dev. What I can say is that you should add a small comment like FIXME just to remember *why* you did that and when you plan to remove that code (so when Nux will feature what we want).

And you added one blank line in the last header file, not sure if that's wanted!

Cheers, thx!

Revision history for this message
Andrea Cimitan (cimi) :
review: Abstain
Revision history for this message
Andrea Cimitan (cimi) wrote :

tested, it is close to the right edge here... doesn-t look like in your screenshot

Revision history for this message
Gord Allott (gordallott) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.