Merge lp://qastaging/~macslow/unity/unity.fix-863246 into lp://qastaging/unity

Proposed by Mirco Müller
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 1832
Proposed branch: lp://qastaging/~macslow/unity/unity.fix-863246
Merge into: lp://qastaging/unity
Diff against target: 503 lines (+156/-170)
4 files modified
plugins/unityshell/resources/dash-widgets.json (+2/-2)
plugins/unityshell/src/DashStyle.cpp (+151/-164)
plugins/unityshell/src/DashStyle.h (+1/-2)
plugins/unityshell/src/FilterGenreWidget.cpp (+2/-2)
To merge this branch: bzr merge lp://qastaging/~macslow/unity/unity.fix-863246
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+88504@code.qastaging.launchpad.net

Description of the change

Since the bug LP: #863246 states so many issues, I'm splitting up the work into a series of branches/fixes. This first part corrects pixel-grid alignment of selected/unselected button-outlines, opacity-values (outline, filling) and vertical and horizontal spacing between buttons.

Here are a few screenshots/screencast showing this first set of improvements:

 http://people.canonical.com/~mmueller/fix-863246-part-1.png
 http://people.canonical.com/~mmueller/fix-863246-part-4.png
 http://people.canonical.com/~mmueller/fix-863246-part-5.ogv

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

+1

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

Attempt to merge into lp:unity failed due to conflicts:

text conflict in plugins/unityshell/resources/dash-widgets.json
text conflict in plugins/unityshell/src/FilterGenreWidget.cpp

Revision history for this message
Unity Merger (unity-merger) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Andrea Azzarone (azzar1) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.