Unity

Merge lp://qastaging/~macslow/unity/unity.fix-913717 into lp://qastaging/unity

  1. unity.fix-913717
  2. Merge into trunk
Proposed by Mirco Müller
Status: Merged
Approved by: Mirco Müller
Approved revision: no longer in the source branch.
Merged at revision: 1828
Proposed branch: lp://qastaging/~macslow/unity/unity.fix-913717
Merge into: lp://qastaging/unity
Diff against target: 19 lines (+2/-3)
1 file modified
plugins/unityshell/src/DashSearchBar.cpp (+2/-3)
To merge this branch: bzr merge lp://qastaging/~macslow/unity/unity.fix-913717
Reviewer Review Type Date Requested Status
John Lea (community) design Approve
Andrea Cimitan (community) Approve
Andrea Azzarone (community) Approve
Review via email: mp+88314@code.qastaging.launchpad.net

Description of the change

Changed rendering of filling of Dash's search-bar according to design-suggestion... http://people.canonical.com/~mmueller/fix-913717.png

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

+1

review: Approve
Revision history for this message
Andrea Cimitan (cimi) wrote :

Is it using the same values as design? It seems pretty close, difficult to test with different backgrounds and dash background color.
If so, +1 for me

review: Approve
Revision history for this message
Andrea Cimitan (cimi) wrote :

Yep, just read the bugreport.

Revision history for this message
John Lea (johnlea) wrote :

Looks great, matches visual design, many thanks!

review: Approve (design)
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/115/console reported an error when processing this lp:~macslow/unity/unity.fix-913717 branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.