Merge lp://qastaging/~majster-pl/ubuntu-calendar-app/new-event-page into lp://qastaging/ubuntu-calendar-app

FAILED: Continuous integration, rev:773
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~majster-pl/ubuntu-calendar-app/new-event-page/+merge/288637/+edit-commit-message

https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/788/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/738/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/788/rebuild

I'm setting this MP as a work in progress since it is. I have added inline comments of all things that needs fixing. This is just a preliminary check since I suspect more changes.

Do note that when I click the add guest button, I get ,

file:///opt/click.ubuntu.com/com.ubuntu.calendar/0.4.latest/NewEvent.qml:726:17: QML ScriptAction: file:///opt/click.ubuntu.com/com.ubuntu.calendar/0.4.latest/NewEvent.qml:728: ReferenceError: addGuestButton is not defined
                            if (addGuestButton.contactsPopup) {

Not sure if this was introduced in your branch or in trunk by some other branch. Please do check to make sure you don't introduce a regression.

I also see file:///opt/click.ubuntu.com/com.ubuntu.calendar/0.4.latest/NewEvent.qml:347:28: Unable to assign [undefined] to QColor

Nice work! It is *almost* ready. Just few minor touch ups to do and then we are set to land this MP.

1. In the old guest design layout, I notice 3 minor issues ( refer to http://imgur.com/HC4JAcs )

a) Remove the listitem dividers of the guests listitem
b) set the guest listitem height as listitemlayout.height. Otherwise it is not centered vertically.
c) Align the guest names to the "Add Guest" button. This can be done by setting the left and right margin to -2 gu. Yes negative :)

2. In the repeat and reminders page, the "Repeat" and "Reminder" listitem header is shown using "blue" color due to the new SDK. Please change these to the new list items to fix this issue.
( refer to http://imgur.com/5yzzm8h )

3. The selection color which is shown when you click on the date/time is a bit strong. Please change the background to lightgray shade and the text color to white/black.

Almost there, just noticed one minor issue. In the Event reminders page, the option "No Reminder" is hidden by the page header. I had a quick look at it, and is quite easy to fix -> http://paste.ubuntu.com/15391380/

LGTM. Awesome work. We can finish of the new design implementation for the Guests feature when we get design specs for it in another MP.

@renato, You can go ahead test this and top-approve. It fixes the label color issue that bill pointed out as well.

Great work.
I added some small comments but in general the code looks great.

Thanks for review, I added few comments.
Will push fixed code soon.

Code looks good, but I can not test it due some conflicts with trunk.

please merge with trunk

FAILED: Continuous integration, rev:779
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~majster-pl/ubuntu-calendar-app/new-event-page/+merge/288637/+edit-commit-message

https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/796/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/798/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-ci/796/rebuild

MR replaced by: https://code.launchpad.net/~majster-pl/ubuntu-calendar-app/new-event-page2/+merge/291516