Merge lp://qastaging/~mandel/desktopcouch/add_windows_keyring into lp://qastaging/desktopcouch
Proposed by
Manuel de la Peña
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Eric Casteleijn | ||||
| Approved revision: | 223 | ||||
| Merged at revision: | 231 | ||||
| Proposed branch: | lp://qastaging/~mandel/desktopcouch/add_windows_keyring | ||||
| Merge into: | lp://qastaging/desktopcouch | ||||
| Diff against target: |
381 lines (+366/-0) 3 files modified
desktopcouch/application/platform/windows/keyring.py (+138/-0) desktopcouch/application/platform/windows/tests/__init__.py (+1/-0) desktopcouch/application/platform/windows/tests/test_keyring.py (+227/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~mandel/desktopcouch/add_windows_keyring | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Eric Casteleijn (community) | Approve | ||
| Chad Miller (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Provides the windows implementation of the keyring that can be used in windows. Data is stored in the Registry and uses the DPAPI so that it is not viewable by a user that has not been logged as the user that owns the registry (apps running in an other user space)
Description of the change
Provides the windows implementation of the keyring that can be used in windows. Data is stored in the Registry and uses the DPAPI so that it is not viewable by a user that has not been logged as the user that owns the registry (apps running in an other user space)
To post a comment you must log in.
Revision history for this message
| Chad Miller (cmiller) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
38 + def __init__(self, make_random_
39 + registry=None, crypto=None):
40 +
If you inherit from object, you much call object's __init__().
> super(Keyring, self).__init__()
73 + for index in count():
Very sexy. Thx.