Merge lp://qastaging/~mandel/desktopcouch/ensure_find_port_name_params into lp://qastaging/desktopcouch

Proposed by Manuel de la Peña
Status: Merged
Approved by: Eric Casteleijn
Approved revision: 236
Merged at revision: 236
Proposed branch: lp://qastaging/~mandel/desktopcouch/ensure_find_port_name_params
Merge into: lp://qastaging/desktopcouch
Diff against target: 11 lines (+1/-1)
1 file modified
desktopcouch/application/platform/linux/ipc.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~mandel/desktopcouch/ensure_find_port_name_params
Reviewer Review Type Date Requested Status
Chad Miller (community) Approve
Eric Casteleijn (community) Approve
John Lenton (community) Approve
Review via email: mp+42668@code.qastaging.launchpad.net

Commit message

Fixed the port advertiser to ensure that the method that retrieves the port does use the correct named param.

Description of the change

Fixed the port advertiser to ensure that the method that retrieves the port does use the correct named param.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

yes, this is the fix. Tests would be nice...

review: Approve
Revision history for this message
Eric Casteleijn (thisfred) wrote :

Approved. Note that we will not close the bug until an integration test for the PortAdvertiser is added.

review: Approve
Revision history for this message
Chad Miller (cmiller) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches