Merge lp://qastaging/~mandel/desktopcouch/mock_db_for_records into lp://qastaging/desktopcouch
Proposed by
Manuel de la Peña
| Status: | Merged | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Manuel de la Peña | ||||||||||||
| Approved revision: | 251 | ||||||||||||
| Merged at revision: | 248 | ||||||||||||
| Proposed branch: | lp://qastaging/~mandel/desktopcouch/mock_db_for_records | ||||||||||||
| Merge into: | lp://qastaging/desktopcouch | ||||||||||||
| Diff against target: |
726 lines (+561/-28) 4 files modified
desktopcouch/application/server.py (+2/-2) desktopcouch/records/database.py (+39/-25) desktopcouch/records/tests/test_mocked_server.py (+519/-0) desktopcouch/records/tests/test_server.py (+1/-1) |
||||||||||||
| To merge this branch: | bzr merge lp://qastaging/~mandel/desktopcouch/mock_db_for_records | ||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Eric Casteleijn (community) | Approve | ||
| Vincenzo Di Somma (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Moved trash db to be an instance variable for bug #697661
Fixed how deleted records ids are generated for bug #697636
Added unit tests in which the db access is mocked for bug #674587
Description of the change
Moved trash db to be an instance variable for bug #697661
Fixed how deleted records ids are generated for bug #697636
Added unit tests in which the db access is mocked for bug #674587
To post a comment you must log in.
Revision history for this message
| Vincenzo Di Somma (vds) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I like it!