Merge lp://qastaging/~mandel/desktopcouch/reactor_already_installed into lp://qastaging/desktopcouch

Proposed by Manuel de la Peña
Status: Merged
Approved by: Natalia Bidart
Approved revision: 200
Merged at revision: 196
Proposed branch: lp://qastaging/~mandel/desktopcouch/reactor_already_installed
Merge into: lp://qastaging/desktopcouch
Diff against target: 137 lines (+32/-23)
3 files modified
bin/desktopcouch-service (+4/-0)
desktopcouch/platform/__init__.py (+11/-6)
desktopcouch/platform/linux/__init__.py (+17/-17)
To merge this branch: bzr merge lp://qastaging/~mandel/desktopcouch/reactor_already_installed
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Alejandro J. Cura (community) Approve
Review via email: mp+40004@code.qastaging.launchpad.net

Commit message

Fix lp:670562 by moving the reactor installation to the service start code.

Description of the change

Fix lp:670562 by moving the reactor installation to the service start code.

To post a comment you must log in.
Revision history for this message
Alejandro J. Cura (alecu) :
review: Approve
198. By Manuel de la Peña

Fix lint errors.

199. By Manuel de la Peña

Remove pairing, there was an error in a previous merge, this hsould not be here :(

200. By Manuel de la Peña

Fixed lint issues.

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

I'm getting the error reported un bug #670600.

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Other than the test failure reported before, the reactor already register issue is solved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches