ubuntu-system-settings

Merge lp://qastaging/~mandel/ubuntu-system-settings/just-notify-on-change into lp://qastaging/ubuntu-system-settings

  1. just-notify-on-change
  2. Merge into trunk
Proposed by Manuel de la Peña
Status: Work in progress
Proposed branch: lp://qastaging/~mandel/ubuntu-system-settings/just-notify-on-change
Merge into: lp://qastaging/ubuntu-system-settings
Prerequisite: lp://qastaging/~mandel/ubuntu-system-settings/mem-leak-fixes
Diff against target: 792 lines (+621/-53)
4 files modified
debian/changelog (+4/-2)
plugins/system-update/update.cpp (+66/-30)
plugins/system-update/update.h (+20/-21)
tests/plugins/system-update/tst_update.cpp (+531/-0)
To merge this branch: bzr merge lp://qastaging/~mandel/ubuntu-system-settings/just-notify-on-change
Reviewer Review Type Date Requested Status
Ken VanDine Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+243628@code.qastaging.launchpad.net

Commit message

Ensure that signals are not emitted when are not needed. Increase test coverage.

Description of the change

The updates plugin notifies of properties changes to the QML even when no changes happened, this should not happen.

To post a comment you must log in.
lp://qastaging/~mandel/ubuntu-system-settings/just-notify-on-change updated
1222. By Manuel de la Peña

Update changelog.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1222
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1842/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/509/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/112
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/443/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/507
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/507/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16488

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1842/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Ken VanDine (ken-vandine) wrote :

There's a merge conflict now

review: Needs Fixing
Reply
Revision history for this message
Sebastien Bacher (seb128) wrote :

setting to wip, please change back to needs review when the review comment is addressed

Reply

Unmerged revisions

1222. By Manuel de la Peña

Update changelog.

1221. By Manuel de la Peña

Ensure that the properties just emit the signals when the value changes and not always.

1219. By Launchpad Translations on behalf of system-settings-touch

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches