ubuntu-system-settings

Merge lp://qastaging/~mandel/ubuntu-system-settings/mem-leak-fixes into lp://qastaging/ubuntu-system-settings

  1. mem-leak-fixes
  2. Merge into trunk
Proposed by Manuel de la Peña
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 1223
Merged at revision: 1231
Proposed branch: lp://qastaging/~mandel/ubuntu-system-settings/mem-leak-fixes
Merge into: lp://qastaging/ubuntu-system-settings
Diff against target: 154 lines (+52/-19)
3 files modified
debian/changelog (+6/-0)
plugins/system-update/download_tracker.cpp (+38/-13)
plugins/system-update/download_tracker.h (+8/-6)
To merge this branch: bzr merge lp://qastaging/~mandel/ubuntu-system-settings/mem-leak-fixes
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+243511@code.qastaging.launchpad.net

Commit message

Fix mem leak in the update page.

Description of the change

The Download pointer returned by the download manager (as stated by the documentation) is owned by the caller and the memory should be managed by the client. This MR cleans the resource in the following cases:

* finished
* canceled
* error

There is also a small change that removes the definitions for a better cpp approach.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1220
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1836/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/477
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/106
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/421
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/477
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/477/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16448

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1836/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Those change looks good, thanks (CI is failing due to issue with the infrastructure)

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

recent changes look fine as well to me. Ken I read that you had issues testing the version before those changes, could you comment on what those were?

review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

I have tested this branch several times in vivid and everything works as expected. Would be nice to get kens feedback too :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches