Music Lens

Merge lp://qastaging/~mandel/unity-lens-music/design-fixes into lp://qastaging/~unity-team/unity-lens-music/libunity7-compatible

design-fixes
Merge into libunity7-compatible

Proposed by Manuel de la Peña on 2013-05-17

Status:

Merged

Approved by:

Paweł Stołowski on 2013-05-17

Approved revision:

162

Merged at revision:

154

Proposed branch:

lp://qastaging/~mandel/unity-lens-music/design-fixes

Merge into:

lp://qastaging/~unity-team/unity-lens-music/libunity7-compatible

Diff against target:

137 lines (+25/-18)

3 files modified

src/album.vala (+4/-2)
src/musicstore-collection.vala (+6/-0)
src/musicstore-scope.vala (+15/-16)

To merge this branch:

bzr merge lp://qastaging/~mandel/unity-lens-music/design-fixes

Related bugs:

Bug #1179981: Purchase error previews must have the prize	Medium	Fix Committed
Bug #1180347: ubuntuone-music-login is not launched when creds are missing	Medium	Fix Committed
Bug #1180717: When a song is free the download button displays a strange price	Medium	Fix Committed
Bug #1182354: Error previews are missing cancel action	Medium	Fix Committed
Bug #1182361: Change payment method opes wrong url (in-dash payments)	High	Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
Paweł Stołowski (community)		2013-05-17	Approve on 2013-05-17
PS Jenkins bot (community)	continuous-integration		Approve on 2013-05-17
Review via email: mp+164332@code.qastaging.launchpad.net

Commit message

- Pass the price to the error previews (LP:1179981)
- Fix spawning of the ubuntuone-credentials app (LP:180347)
- Ensure that free songs say are free and do not use a weird price tag (LP:1180717)

Description of the change

Fixed the following bugs according the reviews done by design:

- Pass the price to the error previews (LP:1179981)
- Fix spawning of the ubuntuone-credentials app (LP:180347)
- Ensure that free songs say are free and do not use a weird price tag (LP:1180717)

Revision history for this message

Manuel de la Peña (mandel) wrote on 2013-05-17:

The simplest way to test this changes IRL is to purge the experimenta ppa (just in case) and do the following:

sudo apt-add-repository ppa:ubuntuone/dashpurchase-testing
sudo apt-get update
sudo apt-get install unity-scope-home ubuntuone-credentials
sudo apt-get upgrade

Once you have done that you can log out, log in and try to purchase songs within the dash.

lp://qastaging/~mandel/unity-lens-music/design-fixes updated on 2013-05-17