Merge lp://qastaging/~manishsinha/cheers/signals-handled into lp://qastaging/~manishsinha/cheers/insertion
Proposed by
Manish Sinha (मनीष सिन्हा)
| Status: | Rejected |
|---|---|
| Rejected by: | Manish Sinha (मनीष सिन्हा) |
| Proposed branch: | lp://qastaging/~manishsinha/cheers/signals-handled |
| Merge into: | lp://qastaging/~manishsinha/cheers/insertion |
| Diff against target: |
262 lines (+111/-23) 7 files modified
README (+2/-1) cheers/client.py (+35/-11) cheers/config.py (+1/-0) cheers/datastore.py (+7/-1) cheers/server.py (+3/-10) cheers/test_client.py (+41/-0) setup.py (+22/-0) |
| To merge this branch: | bzr merge lp://qastaging/~manishsinha/cheers/signals-handled |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Manish Sinha (मनीष सिन्हा) | Disapprove | ||
| Stuart Langridge (community) | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Manish Sinha (मनीष सिन्हा) (manishsinha) wrote | # |
review:
Disapprove
Unmerged revisions
- 21. By Manish Sinha (मनीष सिन्हा)
-
Changed all the wrapper methods in lower case _ seperated names and set the default awarded state to 0
- 20. By Manish Sinha (मनीष सिन्हा)
-
Added event TrophyAwarded, TrophyDeleted and TrophyUnAwarded
- 19. By Manish Sinha (मनीष सिन्हा)
-
Added event callback support, Implemented GetAllSetNames DBus API method and added a test file to run for event handling
- 18. By Manish Sinha (मनीष सिन्हा)
-
Implemented setup script using distutils
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Broadly looks OK to me, although I'm not hugely familiar with the code yet.