Software Properties

Merge lp://qastaging/~manishsinha/software-properties/add-update-after-repo-add into lp://qastaging/software-properties

Proposed by Manish Sinha (मनीष सिन्हा) on 2013-02-23

Status:

Needs review

Proposed branch:

Merge into:

Diff against target:

1 file modified

add-apt-repository (+25/-0)

To merge this branch:

bzr merge lp://qastaging/~manishsinha/software-properties/add-update-after-repo-add

Wishlist

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Terry		2013-02-23	Needs Fixing on 2013-02-25
Review via email: mp+150185@code.qastaging.launchpad.net

Adds a new option -u/--update for updating the source list after a PPA has been added via apt-add-repository

Adds a new option -u/--update for updating the source list after a PPA has been added via apt-add-repository

Revision history for this message

Michael Terry (mterry) wrote on 2013-02-25:

44 + print("YAY")

Should be dropped.

52 - sp.sourceslist.save()
53 + if options.assume_update:
54 + sp.sourceslist.save()

Why does the save move inside the if? It seems like without the -u, you should still save.

review: Needs Fixing

835. By Manish Sinha (मनीष सिन्हा) on 2013-03-01: Move sp.sourceslist.save() above options.assume_update
836. By Manish Sinha (मनीष सिन्हा) on 2013-03-01: The save should be intended 4 chars left else it will never be executed
837. By Manish Sinha (मनीष सिन्हा) on 2013-03-10: Remove YAY print line

837. By Manish Sinha (मनीष सिन्हा) on 2013-03-10: Remove YAY print line
836. By Manish Sinha (मनीष सिन्हा) on 2013-03-01: The save should be intended 4 chars left else it will never be executed
835. By Manish Sinha (मनीष सिन्हा) on 2013-03-01: Move sp.sourceslist.save() above options.assume_update
834. By Manish Sinha (मनीष सिन्हा) on 2013-02-23: Adds a new option -u/--update for updating the source list after a PPA has been added via apt-add-repository