Zeitgeist Sharp

Merge lp://qastaging/~manishsinha/zeitgeist-sharp/fix-651341 into lp://qastaging/~zeitgeist-sharp/zeitgeist-sharp/trunk

  1. fix-651341
  2. Merge into trunk
Status: Merged
Merged at revision: 34
Proposed branch: lp://qastaging/~manishsinha/zeitgeist-sharp/fix-651341
Merge into: lp://qastaging/~zeitgeist-sharp/zeitgeist-sharp/trunk
Diff against target: 1824 lines (+397/-364)
7 files modified
Zeitgeist/Datamodel/Event.cs (+7/-9)
Zeitgeist/Datamodel/Interpretation.cs (+266/-266)
Zeitgeist/Datamodel/Manifestation.cs (+83/-83)
Zeitgeist/Datamodel/NameUri.cs (+34/-0)
Zeitgeist/Datamodel/Subject.cs (+2/-2)
Zeitgeist/Zeitgeist.csproj (+1/-0)
Zeitgeist/ZsUtils.cs (+4/-4)
To merge this branch: bzr merge lp://qastaging/~manishsinha/zeitgeist-sharp/fix-651341
Reviewer Review Type Date Requested Status
Mirco Bauer design, naming, api Approve
Seif Lotfy Pending
Review via email: mp+37337@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Mirco Bauer (meebey) wrote :

Besides the unnice naming of NameUri which is not really descriptive this change looks good to me. The corresponding type in the python API seems to be called Symbol which can hold more fields (like Parent).

review: Approve (design, naming, api)
Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

Well, the upcoming change would be to add the Parent Property.

BTW any other descriptive name instead of NameUri?

Revision history for this message
Mirco Bauer (meebey) wrote :

> Well, the upcoming change would be to add the Parent Property.
>
> BTW any other descriptive name instead of NameUri?

I can't came up with a better one, except copying the type name from the Python API: Symbol

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

Well, will get that done.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches