Merge lp://qastaging/~mar-kolya/ubuntu/raring/acpi-support/fix-for-1184831 into lp://qastaging/ubuntu/raring/acpi-support

Proposed by kolya
Status: Rejected
Rejected by: Brian Murray
Proposed branch: lp://qastaging/~mar-kolya/ubuntu/raring/acpi-support/fix-for-1184831
Merge into: lp://qastaging/ubuntu/raring/acpi-support
Diff against target: 26 lines (+8/-0)
2 files modified
debian/changelog (+6/-0)
lib/policy-funcs (+2/-0)
To merge this branch: bzr merge lp://qastaging/~mar-kolya/ubuntu/raring/acpi-support/fix-for-1184831
Reviewer Review Type Date Requested Status
Brian Murray Disapprove
Review via email: mp+180670@code.qastaging.launchpad.net

Description of the change

This patch adds mate-settings-daemon support to a acpi-support package. This is very similar patch to one already included in LP #1184831, but it helps handling different events (like sleep button).

Note: it looks like currently mate-settings-daemon doesn't support screen blanking when lid is closed and applying this patch would expose this problem. But it looks like that this is actually bug of mate-settings-daemon, not acpi.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

Thanks for proposing this fix, however the version number in debian changelog should be 141.1 as it won't be uploaded to a PPA. Additionally, as this branch is intended for a Stable Release Update for Raring the related bug report should contain SRU information per http://wiki.ubuntu.com/StableReleaseUpdates. Finally, given that the mate desktop environment is not found in the official Ubuntu repositories I don't think this is actually worth performing an SRU for. Sorry!

review: Disapprove

Unmerged revisions

101. By kolya

lib/policy-funcs: add support for mate-settings-daemon. LP: #1184831

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: