Merge lp://qastaging/~marcinello/ubuntu-calendar-app/fix-1297463 into lp://qastaging/ubuntu-calendar-app
Proposed by
Marcin
| Status: | Merged |
|---|---|
| Approved by: | Kunal Parmar |
| Approved revision: | 225 |
| Merged at revision: | 227 |
| Proposed branch: | lp://qastaging/~marcinello/ubuntu-calendar-app/fix-1297463 |
| Merge into: | lp://qastaging/ubuntu-calendar-app |
| Diff against target: |
12 lines (+1/-1) 1 file modified
calendar.qml (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~marcinello/ubuntu-calendar-app/fix-1297463 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
| Alan Pope 🍺🐧🐱 🦄 (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Simply changed default window size to match music-app, calendar-app does not use ConditionalLayout at the moment
Description of the change
Simply changed default window size to match music-app, calendar-app does not use ConditionalLayout at the moment
To post a comment you must log in.
Revision history for this message
| Alan Pope 🍺🐧🐱 🦄 (popey) | # |
review:
Approve
Revision history for this message
| Kunal Parmar (pkunal-parmar) wrote | # |
Revision history for this message
| Alan Pope 🍺🐧🐱 🦄 (popey) wrote | # |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I have few question not related to this changes but general direction.
Does SDK resizes app to phone's screen dimension when on phone ?
And Is SDK planning to provide some hint when its on desktop and when its on Phone and launch app with certain default dimension ?