Unity

Merge lp://qastaging/~marcobiscaro2112/unity/fixes-605475.2 into lp://qastaging/unity

  1. fixes-605475.2
  2. Merge into trunk
Proposed by Marco Biscaro
Status: Superseded
Proposed branch: lp://qastaging/~marcobiscaro2112/unity/fixes-605475.2
Merge into: lp://qastaging/unity
Diff against target: 51 lines (+26/-1)
2 files modified
src/SimpleLauncherIcon.cpp (+24/-0)
src/SimpleLauncherIcon.h (+2/-1)
To merge this branch: bzr merge lp://qastaging/~marcobiscaro2112/unity/fixes-605475.2
Reviewer Review Type Date Requested Status
Mirco Müller (community) Needs Fixing
Review via email: mp+53448@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2011-03-22.

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

Marco, looks mostly fine. But add a sanity check (test against NULL) for data in OnIconThemeChanged() so we won't crash if - for whatever reason - "this" might turn out to be NULL.

review: Needs Fixing
Revision history for this message
Marco Biscaro (marcobiscaro2112) wrote :

I think it's fixed now, Mirco. Could you review it again?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.