Unity

Merge lp://qastaging/~marcobiscaro2112/unity/fixes-742985 into lp://qastaging/unity

fixes-742985
Merge into trunk

Proposed by Marco Biscaro on 2011-03-28

Status:

Rejected

Rejected by:

Didier Roche-Tolomelli on 2011-04-08

Proposed branch:

lp://qastaging/~marcobiscaro2112/unity/fixes-742985

Merge into:

lp://qastaging/unity

Diff against target:

18 lines (+3/-2)

1 file modified

src/Launcher.cpp (+3/-2)

To merge this branch:

bzr merge lp://qastaging/~marcobiscaro2112/unity/fixes-742985

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Didier Roche-Tolomelli		2011-03-28	Disapprove on 2011-03-28
Review via email: mp+55164@code.qastaging.launchpad.net

Description of the change

Check the value of the shortcut before attempting to draw his character.

Revision history for this message

Marco Biscaro (marcobiscaro2112) wrote on 2011-03-28:

The problem is already fixed on trunk, but merging with this branch can prevent other similar problems in future (see https://bugs.launchpad.net/askubuntu-lens/+bug/742985/comments/4).

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2011-03-28:

Hey Marco, I'm afraid this is invalid for now.

Indeed, shortcut is a gint, so it can be > 32 (like for a, f and t…) but the fix I was discussing is still in my branch (it's at the other hand). And for that, we need to check that the shortcut != 0 as 0 is the initial value :)

Hope that the explanations helps! Thanks however for your strong merge and participation commitment for unity. There is still a lot of bitesize around (if you need any pointer, to not hesitate to join irc!) :)

review: Disapprove

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2011-04-08:

Setting the state to reject as my previous comment to clean the list and you proposed another branch making that :)

BTW, do you know that there is a "resubmit proposal" button that can automatically superseed this proposal?