Unity

Merge lp://qastaging/~marcobiscaro2112/unity/fixes-748676 into lp://qastaging/unity

  1. fixes-748676
  2. Merge into trunk
Proposed by Marco Biscaro
Status: Merged
Merged at revision: 1147
Proposed branch: lp://qastaging/~marcobiscaro2112/unity/fixes-748676
Merge into: lp://qastaging/unity
Diff against target: 182 lines (+77/-5)
4 files modified
src/PanelHomeButton.cpp (+64/-3)
src/PanelHomeButton.h (+5/-0)
src/PanelStyle.cpp (+6/-2)
src/PanelStyle.h (+2/-0)
To merge this branch: bzr merge lp://qastaging/~marcobiscaro2112/unity/fixes-748676
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+58007@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-04-07.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote : Posted in a previous version of this proposal

Hey Marco, really awesome work! :)
I just set the branch as Need information as it needs design request, UI freeze exception and such, feel free to reput the branch in another state once we will have an answer :)

Otherwise, the code looks good!

review: Needs Information
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Looks excellent Marco!
Last week, I was planning to add the Unregistering interest in ubus but you did it meanwhile! Thanks ;)
I just took the liberty to add a one pixel offset vertically as well as I found that just moving it right was weird.

Excellent work, merging ;)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.