Juju Charms Collection
mysql package

Merge lp://qastaging/~marcoceppi/charms/trusty/mysql/lp1373862 into lp://qastaging/charms/trusty/mysql

  1. Trusty Tahr (14.04)
  2. lp1373862
  3. Merge into trunk
Proposed by Marco Ceppi
Status: Work in progress
Proposed branch: lp://qastaging/~marcoceppi/charms/trusty/mysql/lp1373862
Merge into: lp://qastaging/charms/trusty/mysql
Diff against target: 11 lines (+1/-1)
1 file modified
config.yaml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~marcoceppi/charms/trusty/mysql/lp1373862
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Needs Information
charmers Pending
Review via email: mp+267948@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #7988 mysql for marcoceppi mp267948
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/7988/

Reply
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #7403 mysql for marcoceppi mp267948
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/12071051/
Build: http://10.245.162.77:8080/job/charm_unit_test/7403/

Reply
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Please see comment on bug 1373862.

If we do move forward with this default value change, we will need to update the amulet test as well.

The test knows about the former 80% default charm config value, in the interest of making sure the "deployed" == the "expected."

As an aside, the unit tests are known-failing (bug 1398918), as they're not really mocking.

review: Disapprove
Reply
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Marco - can you rebase your proposed branch to ensure that the other landed changes are pulled into this for testing?

Reply
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Marco - can you rebase your proposed branch to ensure that the other landed changes are pulled into this for testing?

review: Needs Information
Reply

Unmerged revisions

147. By Marco Ceppi

Sane dataset-size. Fixes local provider and is recommended value from MySQL experts

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: