Granite

Merge lp://qastaging/~marcus-lundgren/granite/fix-1062967 into lp://qastaging/~elementary-pantheon/granite/granite

  1. fix-1062967
  2. Merge into granite
Proposed by Marcus Lundgren
Status: Merged
Merged at revision: 518
Proposed branch: lp://qastaging/~marcus-lundgren/granite/fix-1062967
Merge into: lp://qastaging/~elementary-pantheon/granite/granite
Diff against target: 38 lines (+10/-4)
1 file modified
lib/Widgets/DecoratedWindow.vala (+10/-4)
To merge this branch: bzr merge lp://qastaging/~marcus-lundgren/granite/fix-1062967
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
David Gomes (community) Approve
Review via email: mp+143180@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
David Gomes (davidgomes) wrote :

if(on_close_button){
↓
if (on_close_button) {

Also, the following looks much better than what you have on line 9.

this.add_events (Gdk.EventMask.BUTTON_PRESS_MASK |
                 Gdk.EventMask.BUTTON_RELEASE_MASK |
                 Gdk.EventMask.POINTER_MOTION_MASK);

Also, please no trailing space like on line 34.

Revision history for this message
David Gomes (davidgomes) wrote :

Oops, here's the Needs Fixing.

review: Approve
lp://qastaging/~marcus-lundgren/granite/fix-1062967 updated
519. By Marcus Lundgren

Code style.

520. By Marcus Lundgren

Trailing whitespace.

Revision history for this message
Cody Garver (codygarver) wrote :

Woohoo!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches