Merge lp://qastaging/~marcustomlinson/unity-scopes-api/fix_oa_refresh into lp://qastaging/unity-scopes-api/devel

Proposed by Marcus Tomlinson
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 553
Merged at revision: 552
Proposed branch: lp://qastaging/~marcustomlinson/unity-scopes-api/fix_oa_refresh
Merge into: lp://qastaging/unity-scopes-api/devel
Diff against target: 71 lines (+7/-43)
2 files modified
src/scopes/internal/OnlineAccountClientImpl.cpp (+7/-0)
test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp (+0/-43)
To merge this branch: bzr merge lp://qastaging/~marcustomlinson/unity-scopes-api/fix_oa_refresh
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+243516@code.qastaging.launchpad.net

Commit message

* Update the accounts we already know about when refresh_service_statuses() is called.

* Remove the refresh_services_no_main_loop test as refresh_service_statuses() just won't work without a main loop (this test passed incorrectly before)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

LGTM. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: