Merge lp://qastaging/~marcustomlinson/unity-scopes-api/strict_idle_timeout into lp://qastaging/unity-scopes-api/devel
Proposed by
Marcus Tomlinson
Status: | Merged |
---|---|
Approved by: | Marcus Tomlinson |
Approved revision: | 691 |
Merged at revision: | 690 |
Proposed branch: | lp://qastaging/~marcustomlinson/unity-scopes-api/strict_idle_timeout |
Merge into: | lp://qastaging/unity-scopes-api/devel |
Diff against target: |
46 lines (+6/-6) 3 files modified
doc/tutorial.dox (+2/-1) src/scopes/internal/ScopeConfig.cpp (+3/-4) test/gtest/scopes/internal/ScopeConfig/ScopeConfig_test.cpp (+1/-1) |
To merge this branch: | bzr merge lp://qastaging/~marcustomlinson/unity-scopes-api/strict_idle_timeout |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
unity-api-1-bot | continuous-integration | Approve | |
Marcus Tomlinson (community) | Approve | ||
Michi Henning | Pending | ||
Review via email: mp+308346@code.qastaging.launchpad.net |
This proposal supersedes a proposal from 2016-10-12.
Commit message
Be much stricter on idle timeout (1s to 5min)
Description of the change
Be much stricter on idle timeout (1s to 5min). Not only are scopes currently allowed to set very very large timeouts, we seem to allow disabling of the timeout entirely (a value of -1)
To post a comment you must log in.
Looks good to me. Did we have problems with a scopes setting unreasonable values?
Not sure where the -1 problem is. The previous code complained if the value was < 0, meaning that you can have a scope that times out immediately. (Not that useful, I admit.)
I can't recall why we allowed maxint :-(