Merge lp://qastaging/~marcustomlinson/unity-scopes-api/switch-to-net-cpp into lp://qastaging/unity-scopes-api

PASSED: Continuous integration, rev:183
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-ci/514/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-amd64-ci/39
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/39
        deb: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/39/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-i386-ci/39

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-ci/514/rebuild

Looks good, thanks!

A few minor quibbles:

Please don't use uint anywhere. It's not a C++ type, and whether it works or not depends on whether some random header happens to drag in sys/types.h. Use unsigned int instead. (uint also causes warnings from doxygen when building the developer doc because it ends up not being able to match the signature in some cases.)

And, as an aside, try to not use unsigneds at all. They are evil. (See John Lakos for a really good explanation.)

76 + explicit HttpClientNetCpp(uint no_reply_timeout);
86 + void cancel_get(uint session_id) override;
88 + uint no_reply_timeout;
416 + std::pair<uint, std::shared_ptr<Cancelable>> add()
424 + uint add(const std::shared_ptr<Cancelable>& cancelable)
428 + uint result{++request_id};
435 + void cancel_and_remove_for_id(uint id)
448 + uint request_id{0};
450 + std::unordered_map<uint, std::shared_ptr<Cancelable>> store;
454 +HttpClientNetCpp::HttpClientNetCpp(uint no_reply_timeout)
529 +void HttpClientNetCpp::cancel_get(uint id)
923 HttpClientTest(uint no_reply_timeout = 20000)

It would be good to ditch the static library for smartscopes, I don't think we need it anymore.

While you are working on this anyway, would you mind making the lineData lambda thread-safe? At the moment, it appends to the string from a different thread without a lock.

Also, the lineData param should be called line_data instead.

Minor style issue here:

506 + } else
507 + {

And here (missing curlies):

465 + if (worker.joinable())
466 + worker.join();

PASSED: Continuous integration, rev:188
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-ci/521/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-amd64-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/46
        deb: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/46/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-i386-ci/46

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-ci/521/rebuild

Thanks for that!

One request (please forgive me for being anal):

10 +find_library(ZMQPPLIB zmqpp)
11 +if(NOT ZMQPPLIB)
12 + message(FATAL_ERROR "Zmqpp lib not found.")
13 +endif()

I think this is nice. Without this, cmake says:

CMake Error at CMakeLists.txt:122 (message):
   Capnp compiler not found.

But it would be a *lot* nicer if it actually told me the package name instead of "Zmqpp lib not found".

I can't count the number of times where some sort of install script told me that command "foo" or library "libxyz" couldn't be found, and then I have to spend five minutes trying to figure out which package bloody "foo" or "libxyz" can be found in.

So, I'd change the error messages to actually spell out the package name "package capnproto not found". That way, I can just copy and paste: "apt-get install capnproto" and Bob's my uncle :-)

FAILED: Continuous integration, rev:189
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-ci/523/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-amd64-ci/48/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/48/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-i386-ci/48/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-ci/523/rebuild

> Thanks for that!
>
> One request (please forgive me for being anal):
>
> 10 +find_library(ZMQPPLIB zmqpp)
> 11 +if(NOT ZMQPPLIB)
> 12 + message(FATAL_ERROR "Zmqpp lib not found.")
> 13 +endif()
>
> I think this is nice. Without this, cmake says:
>
> CMake Error at CMakeLists.txt:122 (message):
> Capnp compiler not found.
>
> But it would be a *lot* nicer if it actually told me the package name instead
> of "Zmqpp lib not found".
>
> I can't count the number of times where some sort of install script told me
> that command "foo" or library "libxyz" couldn't be found, and then I have to
> spend five minutes trying to figure out which package bloody "foo" or "libxyz"
> can be found in.
>
> So, I'd change the error messages to actually spell out the package name
> "package capnproto not found". That way, I can just copy and paste: "apt-get
> install capnproto" and Bob's my uncle :-)

k, done

Thanks for that, and thanks for your diligence!

Not sure what was broken with Jenkins last time around. Top-approving to see what happens.

Fixed some small stupid mistakes (191 and 192), top approving again