Merge lp://qastaging/~marcustomlinson/unity-scopes-shell/oa_ui_policy-rtm into lp://qastaging/unity-scopes-shell/rtm-14.09

Proposed by Marcus Tomlinson
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 134
Merged at revision: 142
Proposed branch: lp://qastaging/~marcustomlinson/unity-scopes-shell/oa_ui_policy-rtm
Merge into: lp://qastaging/unity-scopes-shell/rtm-14.09
Diff against target: 66 lines (+24/-5)
2 files modified
src/Unity/CMakeLists.txt (+1/-1)
src/Unity/scope.cpp (+23/-4)
To merge this branch: bzr merge lp://qastaging/~marcustomlinson/unity-scopes-shell/oa_ui_policy-rtm
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
Review via email: mp+244388@code.qastaging.launchpad.net

Commit message

* Set UNITY_SCOPES_OA_UI_POLICY on entry to Scope::loginToAccount()
* Animate the loading bar on the scope while OA retrieves a token.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

+1

review: Approve
Revision history for this message
Paweł Stołowski (stolowski) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: