unity-scopes-shell

Merge lp://qastaging/~marcustomlinson/unity-scopes-shell/oa_ui_policy into lp://qastaging/unity-scopes-shell

  1. oa_ui_policy
  2. Merge into trunk
Proposed by Marcus Tomlinson
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 177
Merged at revision: 176
Proposed branch: lp://qastaging/~marcustomlinson/unity-scopes-shell/oa_ui_policy
Merge into: lp://qastaging/unity-scopes-shell
Diff against target: 14 lines (+4/-0)
1 file modified
src/Unity/scope.cpp (+4/-0)
To merge this branch: bzr merge lp://qastaging/~marcustomlinson/unity-scopes-shell/oa_ui_policy
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
Review via email: mp+244264@code.qastaging.launchpad.net

Commit message

Set UNITY_SCOPES_OA_UI_POLICY on entry to Scope::loginToAccount()

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

+ setenv("UNITY_SCOPES_OA_UI_POLICY", "1", 1);

Could you please add a comment explaining what it does and why?

review: Needs Fixing
lp://qastaging/~marcustomlinson/unity-scopes-shell/oa_ui_policy updated
176. By Marcus Tomlinson

replace = 0

177. By Marcus Tomlinson

Added a comment

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

> + setenv("UNITY_SCOPES_OA_UI_POLICY", "1", 1);
>
> Could you please add a comment explaining what it does and why?

Done

Revision history for this message
Paweł Stołowski (stolowski) wrote :

LGTM. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: