Online Accounts: Account plugins

Merge lp://qastaging/~mardy/account-plugins/mcloud-plugin-lp1587282 into lp://qastaging/~gary-wzl77/account-plugins/mcloud-plugin-lp1587282

  1. mcloud-plugin-lp1587282
  2. Merge into mcloud-plugin-lp1587282
Proposed by Alberto Mardegan
Status: Needs review
Proposed branch: lp://qastaging/~mardy/account-plugins/mcloud-plugin-lp1587282
Merge into: lp://qastaging/~gary-wzl77/account-plugins/mcloud-plugin-lp1587282
Diff against target: 1210 lines (+351/-510)
27 files modified
.bzrignore (+5/-0)
Makefile.am (+26/-6)
configure.ac (+4/-1)
data/providers/facebook.provider.in.in (+1/-1)
data/providers/flickr.provider.in.in (+1/-1)
data/providers/mcloud.provider.in.in (+4/-5)
data/providers/twitter.provider.in.in (+1/-1)
data/webkit-options/api.twitter.com.conf (+0/-2)
data/webkit-options/login.yahoo.com.conf (+0/-2)
data/webkit-options/www.facebook.com.conf (+0/-7)
debian/account-plugin-facebook.install (+0/-1)
debian/account-plugin-flickr.install (+0/-1)
debian/account-plugin-twitter.install (+0/-1)
debian/changelog (+34/-0)
debian/control (+73/-52)
debian/libaccount-plugin-facebook.install (+1/-0)
debian/libaccount-plugin-flickr.install (+1/-0)
debian/libaccount-plugin-twitter.install (+1/-0)
qml/Makefile.am (+1/-0)
qml/mcloud/ErrorItem.qml (+0/-48)
qml/mcloud/Main.qml (+2/-3)
qml/mcloud/OAuth.qml (+0/-283)
qml/mcloud/WebView.qml (+0/-94)
src/facebook.vala (+69/-0)
src/flickr.vala (+41/-0)
src/google.vala (+40/-1)
src/twitter.vala (+46/-0)
To merge this branch: bzr merge lp://qastaging/~mardy/account-plugins/mcloud-plugin-lp1587282
Reviewer Review Type Date Requested Status
Gary.Wang Approve
Review via email: mp+296288@code.qastaging.launchpad.net

Description of the change

Use the web based flow for authentication

To post a comment you must log in.
lp://qastaging/~mardy/account-plugins/mcloud-plugin-lp1587282 updated
165. By Alberto Mardegan

Enable state parameter

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Thanks for this MP, mandy.
It looks good to me.

I know the reason why you apply this change in the signon-plugin-oauth (https://gitlab.com/accounts-sso/signon-plugin-oauth2/commit/e812eb3e76a1221074e3cf27208aacced5091e42).
And modify the TokenPath here accordingly. :)
...
<setting name="TokenPath">https://ose.caiyun.feixin.10086.cn/oauthApp/OAuth2/getToken</setting>
...

I'd like to test it on my side with my phone, could you please give me the silo number for accounts-sso/signon-plugin-oauth2 with your patch applied after you finish verification.
Thanks.

Reply
Revision history for this message
Alberto Mardegan (mardy) wrote :

> I'd like to test it on my side with my phone, could you please give me the
> silo number for accounts-sso/signon-plugin-oauth2 with your patch applied
> after you finish verification.

That will probably take some days, as I still need people to review the upstream changes.

But I've uploaded the package to my personal PPA here:
https://launchpad.net/~mardy/+archive/ubuntu/phablet/+packages

While I'm writing this the signon-plugin-oauth is still building on armhf, but it should be ready soon.

Reply
Revision history for this message
Gary.Wang (gary-wzl77) wrote :

I install latest signon-plugin-oauth package (armhf) on my device from your PPA , and run several tests. Mcloud scopes and camera app with mcloud integration both works very well.
Thanks mandy.
So let's wait for signon-plugin-oauth upstream review.

review: Approve
Reply
Revision history for this message
Alberto Mardegan (mardy) wrote :

Upstream review was faster than expected. I've put the OAuth plugin in silo 59, the CI ticket is this one:
https://requests.ci-train.ubuntu.com/#/ticket/1497

If you don't have objections, I will also take this branch and put it in the same silo, so that it will be easier to test.

Reply
Revision history for this message
Gary.Wang (gary-wzl77) wrote :

That's so nice.
No problem.
Thanks.

Reply
lp://qastaging/~mardy/account-plugins/mcloud-plugin-lp1587282 updated
166. By Alberto Mardegan

Merge from trunk

* debian/control:
  Update package descriptions for all account plugins (LP: #1590786)
[ Alberto Mardegan ]
* Add account plugin for vk.com (LP: #1564883)
* Add ownCloud plugin (LP: #1570986)
[ Alberto Mardegan ]
* After the authentication, retrieve the username in Google, Facebook,
  Flickr and Twitter plugins (LP: #1565772)
* debian/control, debian/libaccount-plugin-facebook.install,
  debian/libaccount-plugin-flickr.install,
  debian/libaccount-plugin-twitter.install:
  add packages containing plugin modules.
* debian/account-plugin-facebook.install,
  debian/account-plugin-flickr.install,
  debian/account-plugin-twitter.install:
  remove unneeded webkit-options files.
[ CI Train Bot ]
* No-change rebuild.

167. By Alberto Mardegan

Update description

Unmerged revisions

167. By Alberto Mardegan

Update description

166. By Alberto Mardegan

Merge from trunk

* debian/control:
  Update package descriptions for all account plugins (LP: #1590786)
[ Alberto Mardegan ]
* Add account plugin for vk.com (LP: #1564883)
* Add ownCloud plugin (LP: #1570986)
[ Alberto Mardegan ]
* After the authentication, retrieve the username in Google, Facebook,
  Flickr and Twitter plugins (LP: #1565772)
* debian/control, debian/libaccount-plugin-facebook.install,
  debian/libaccount-plugin-flickr.install,
  debian/libaccount-plugin-twitter.install:
  add packages containing plugin modules.
* debian/account-plugin-facebook.install,
  debian/account-plugin-flickr.install,
  debian/account-plugin-twitter.install:
  remove unneeded webkit-options files.
[ CI Train Bot ]
* No-change rebuild.

165. By Alberto Mardegan

Enable state parameter

164. By Alberto Mardegan

Change token path

163. By Alberto Mardegan

Use web_server mechanism

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: