poll-daemon

Merge lp://qastaging/~mardy/account-polld/dekko-gmail into lp://qastaging/~ubuntu-push-hackers/account-polld/trunk

  1. dekko-gmail
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 170
Merged at revision: 174
Proposed branch: lp://qastaging/~mardy/account-polld/dekko-gmail
Merge into: lp://qastaging/~ubuntu-push-hackers/account-polld/trunk
Prerequisite: lp://qastaging/~mardy/account-polld/skip-unsupported
Diff against target: 521 lines (+479/-0)
3 files modified
cmd/account-polld/main.go (+6/-0)
plugins/dekko/api.go (+127/-0)
plugins/dekko/dekko.go (+346/-0)
To merge this branch: bzr merge lp://qastaging/~mardy/account-polld/dekko-gmail
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
system-apps-ci-bot continuous-integration Approve
Review via email: mp+300873@code.qastaging.launchpad.net

Commit message

Add Dekko GMail plugin

Description of the change

Add Dekko GMail plugin

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:170
https://jenkins.canonical.com/system-apps/job/lp-account-polld-ci/15/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/1032
    SUCCESS: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/200
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1032
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/929
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/929
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/929
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/923
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/923/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/923
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/923/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/923
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/923/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/923
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/923/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/923
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/923/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/923
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/923/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/923
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/923/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/923
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/923/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/923
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/923/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-account-polld-ci/15/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

Everything looks okay, except for the duplication of some code from the gmail plugin. Have you looked at the possibility of sharing some of the code?

review: Needs Information
Revision history for this message
Alberto Mardegan (mardy) wrote :

> Everything looks okay, except for the duplication of some code from the gmail
> plugin. Have you looked at the possibility of sharing some of the code?

I haven't. :-) The reason is that the plan is to extend account-polld to support out-of-process plugins, after which we could reuse Dekko's own IMAP/POP3 client implementation and drop this plugin altogether.
You can read more about this in bug 1421923, from comment #18 on.

Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

Then let's not invest too much time and energy in introducing some sort of code sharing between plugins—that may benefit from being completely separate packages anyway.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches