Merge lp://qastaging/~mardy/gnome-control-center-signon/dont-report-failures into lp://qastaging/gnome-control-center-signon

Proposed by Alberto Mardegan
Status: Merged
Approved by: Ken VanDine
Approved revision: 150
Merged at revision: 149
Proposed branch: lp://qastaging/~mardy/gnome-control-center-signon/dont-report-failures
Merge into: lp://qastaging/gnome-control-center-signon
Diff against target: 45 lines (+7/-16)
2 files modified
debian/changelog (+7/-2)
src/cc-credentials-authorization-page.vala (+0/-14)
To merge this branch: bzr merge lp://qastaging/~mardy/gnome-control-center-signon/dont-report-failures
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot (community) continuous-integration Approve
Online Accounts Pending
Review via email: mp+161950@code.qastaging.launchpad.net

Commit message

Don't report account failures

Account failures are reported either by applications of by signon-ui. This
fixes a bug occurring when the account creation fails and the Online Accounts
indicator turns red.

Description of the change

Don't report account failures

Account failures are reported either by applications of by signon-ui. This
fixes a bug occurring when the account creation fails and the Online Accounts
indicator turns red.

This also increases test coverage. ;-)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Awesome, glad the coverage went up :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches