Merge lp://qastaging/~mardy/gnome-control-center-signon/lp1066917 into lp://qastaging/gnome-control-center-signon
Proposed by
Alberto Mardegan
| Status: | Merged |
|---|---|
| Approved by: | David King |
| Approved revision: | 113 |
| Merged at revision: | 112 |
| Proposed branch: | lp://qastaging/~mardy/gnome-control-center-signon/lp1066917 |
| Merge into: | lp://qastaging/gnome-control-center-signon |
| Diff against target: |
83 lines (+22/-9) 2 files modified
configure.ac (+2/-6) libaccount-plugin/oauth-plugin.c (+20/-3) |
| To merge this branch: | bzr merge lp://qastaging/~mardy/gnome-control-center-signon/lp1066917 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David King (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Description of the change
Pack the cookies into a GVariant
Instead of directly passing the cookies GHashTable as a GValue (which the
recent versions of libsignon-glib cannot handle anymore), repack it into a
GVariant and put that into a GValue.
As a nice side-effect, we can now remove the dbus-glib dependency which is no
longer needed.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Alberto Mardegan (mardy) wrote | # |
Revision history for this message
| David King (amigadave) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks fine.