Online Accounts: GNOME Control Center

Merge lp://qastaging/~mardy/gnome-control-center-signon/no-params-needed into lp://qastaging/gnome-control-center-signon

  1. no-params-needed
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 141
Merged at revision: 138
Proposed branch: lp://qastaging/~mardy/gnome-control-center-signon/no-params-needed
Merge into: lp://qastaging/gnome-control-center-signon
Diff against target: 256 lines (+77/-42)
3 files modified
configure.ac (+1/-1)
debian/control (+1/-1)
libaccount-plugin/oauth-plugin.c (+75/-40)
To merge this branch: bzr merge lp://qastaging/~mardy/gnome-control-center-signon/no-params-needed
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
David King (community) Approve
Review via email: mp+150048@code.qastaging.launchpad.net

Commit message

OAuthPlugin: do not require mechanism or parameters

They can all be read from the .provider files.

Description of the change

OAuthPlugin: do not require mechanism or parameters

They can all be read from the .provider files.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:137
http://s-jenkins:8080/job/gnome-control-center-signon-ci/28/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=amd64/28/console
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=i386/28/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gnome-control-center-signon-ci/28//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:138
http://s-jenkins:8080/job/gnome-control-center-signon-ci/29/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=amd64/29/console
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=i386/29/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gnome-control-center-signon-ci/29//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:139
http://s-jenkins:8080/job/gnome-control-center-signon-ci/30/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=amd64/30/console
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=i386/30/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gnome-control-center-signon-ci/30//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
David King (amigadave) wrote :

42 +static inline const gchar *

inline? If you really mean it, add a check in configure.ac (AC_C_INLINE).

review: Needs Fixing
Revision history for this message
Alberto Mardegan (mardy) wrote :

> 42 +static inline const gchar *
>
> inline? If you really mean it, add a check in configure.ac (AC_C_INLINE).

I guess I can remove it and leave the optimization to the compiler. It's not really in a speed-critical code path :-)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:140
http://s-jenkins:8080/job/gnome-control-center-signon-ci/31/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=amd64/31/console
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=i386/31/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gnome-control-center-signon-ci/31//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:140
http://s-jenkins:8080/job/gnome-control-center-signon-ci/32/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=amd64/32/console
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=i386/32/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gnome-control-center-signon-ci/32//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:140
http://s-jenkins:8080/job/gnome-control-center-signon-ci/33/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=amd64/33/console
    SUCCESS: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=i386/33/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gnome-control-center-signon-ci/33//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:140
http://s-jenkins:8080/job/gnome-control-center-signon-ci/34/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=amd64/34/console
    SUCCESS: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=i386/34/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gnome-control-center-signon-ci/34//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
David King (amigadave) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://s-jenkins:8080/job/gnome-control-center-signon-autolanding/16/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-autolanding/./build=pbuilder,distribution=raring,flavor=amd64/16/console
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-autolanding/./build=pbuilder,distribution=raring,flavor=i386/16/console

review: Needs Fixing (continuous-integration)
lp://qastaging/~mardy/gnome-control-center-signon/no-params-needed updated
141. By Alberto Mardegan

[ Didier Roche ]
[ Rico Tzschichholz ]
Fix dev-package dependencies

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches