Merge lp://qastaging/~mardy/gnome-control-center-signon/username-1565772 into lp://qastaging/~online-accounts/gnome-control-center-signon/16.04
| Status: | Approved |
|---|---|
| Approved by: | David Barth |
| Approved revision: | 187 |
| Proposed branch: | lp://qastaging/~mardy/gnome-control-center-signon/username-1565772 |
| Merge into: | lp://qastaging/~online-accounts/gnome-control-center-signon/16.04 |
| Diff against target: |
250 lines (+65/-24) 5 files modified
debian/changelog (+8/-0) debian/libaccount-plugin-1.0-0.symbols (+2/-0) libaccount-plugin/AccountPlugin.vapi (+3/-0) libaccount-plugin/oauth-plugin.c (+49/-23) libaccount-plugin/oauth-plugin.h (+3/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mardy/gnome-control-center-signon/username-1565772 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Online Accounts | Pending | ||
|
Review via email:
|
|||
Commit message
Allow OAuth-based account plugins to override display name
Add a virtual method to allow account plugins to retrieve the user name, typically via REST API calls to the remote service. This will allow us to get rid of the ugly hack in signon-ui, where we retrieve the username by inspecting the DOM of the webpages.
Description of the change
Allow OAuth-based account plugins to override display name
Add a virtual method to allow account plugins to retrieve the user name, typically via REST API calls to the remote service. This will allow us to get rid of the ugly hack in signon-ui, where we retrieve the username by inspecting the DOM of the webpages.
Unmerged revisions
- 187. By Alberto Mardegan
-
formatting
- 186. By Alberto Mardegan
-
Update symbols and vapi file
- 185. By Alberto Mardegan
-
Allows plugins to override query username logic
- 184. By Alberto Mardegan
-
Add API to retrieve authentication reply
