Merge lp://qastaging/~mardy/libsignon-glib/context-lp1607799 into lp://qastaging/libsignon-glib

Proposed by Alberto Mardegan
Status: Merged
Approved by: Marcus Tomlinson
Approved revision: 164
Merged at revision: 163
Proposed branch: lp://qastaging/~mardy/libsignon-glib/context-lp1607799
Merge into: lp://qastaging/libsignon-glib
Diff against target: 111 lines (+22/-32)
3 files modified
debian/changelog (+7/-0)
libsignon-glib/signon-proxy.c (+15/-9)
tests/check_signon.c (+0/-23)
To merge this branch: bzr merge lp://qastaging/~mardy/libsignon-glib/context-lp1607799
Reviewer Review Type Date Requested Status
Marcus Tomlinson (community) Approve
Review via email: mp+301644@code.qastaging.launchpad.net

Commit message

Lib: don't use g_idle_add, respect thread affinity

After commit 4e85baaf483268d04bbf835bebeac4ae30c7c327 libsignon-glib
stopped working when used in a thread on which
g_main_context_push_thread_default() had been called: the reason is that
g_idle_add()'s callback is always involved on the default GMainContext,
and not on the one used by the current thread.

We fix this problem by using g_source directly.

Description of the change

Lib: don't use g_idle_add, respect thread affinity

After commit 4e85baaf483268d04bbf835bebeac4ae30c7c327 libsignon-glib
stopped working when used in a thread on which
g_main_context_push_thread_default() had been called: the reason is that
g_idle_add()'s callback is always involved on the default GMainContext,
and not on the one used by the current thread.

We fix this problem by using g_source directly.

To post a comment you must log in.
164. By Alberto Mardegan

Changelog

* Merge from upstream.
  - Lib: don't use g_idle_add, respect thread affinity (LP: #1607799)

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Excellent work, thanks mardy.

review: Approve
165. By Alberto Mardegan

Merge from upstream

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: