Merge lp://qastaging/~mardy/online-accounts-api/timeout-1603706 into lp://qastaging/online-accounts-api

Proposed by Alberto Mardegan
Status: Merged
Approved by: James Henstridge
Approved revision: 24
Merged at revision: 24
Proposed branch: lp://qastaging/~mardy/online-accounts-api/timeout-1603706
Merge into: lp://qastaging/online-accounts-api
Diff against target: 255 lines (+68/-44)
3 files modified
tests/daemon/functional_tests/daemon_interface.cpp (+2/-2)
tests/daemon/functional_tests/daemon_interface.h (+1/-1)
tests/daemon/functional_tests/functional_tests.cpp (+65/-41)
To merge this branch: bzr merge lp://qastaging/~mardy/online-accounts-api/timeout-1603706
Reviewer Review Type Date Requested Status
James Henstridge Approve
Review via email: mp+300416@code.qastaging.launchpad.net

Commit message

Tests: keep the service alive while running the test

On slower machines, the D-Bus service can timeout during the execution of the testAccountChanges() test, causing it to fail.
With this change each test is run in its own D-Bus session, with a 30 seconds timeout, and only the testLifetime() has a shorter timeout, needed to test the auto-quitting functionality.

Description of the change

Tests: keep the service alive while running the test

On slower machines, the D-Bus service can timeout during the execution of the testAccountChanges() test, causing it to fail.
With this change each test is run in its own D-Bus session, with a 30 seconds timeout, and only the testLifetime() has a shorter timeout, needed to test the auto-quitting functionality.

To post a comment you must log in.
Revision history for this message
James Henstridge (jamesh) wrote :

There were two failed builds with this MP added to the silo. I've left details about them in the attached bug report together with links to the build logs:

https://bugs.launchpad.net/ubuntu/+source/online-accounts-api/+bug/1603706/comments/3

23. By Alberto Mardegan

Revert

24. By Alberto Mardegan

Tests: restart the D-Bus session with each test

Revision history for this message
James Henstridge (jamesh) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches