Ubuntu Notes app

Merge lp://qastaging/~mardy/reminders-app/new-api into lp://qastaging/reminders-app

  1. new-api
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Needs review
Proposed branch: lp://qastaging/~mardy/reminders-app/new-api
Merge into: lp://qastaging/reminders-app
Diff against target: 408 lines (+97/-89)
8 files modified
CMakeLists.txt (+4/-0)
com.ubuntu.reminders_reminders.accounts.in (+8/-0)
debian/control (+5/-6)
manifest.json.in (+2/-4)
src/account-plugin/CMakeLists.txt (+5/-0)
src/account-plugin/com.ubuntu.reminders_evernote-account-plugin.accounts.in (+22/-0)
src/app/qml/Reminders.qml (+44/-62)
src/app/qml/ui/AccountSelectorPage.qml (+7/-17)
To merge this branch: bzr merge lp://qastaging/~mardy/reminders-app/new-api
Reviewer Review Type Date Requested Status
David Planella Needs Information
Jenkins Bot continuous-integration Needs Fixing
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+271505@code.qastaging.launchpad.net

Commit message

Use the new Online Accounts API and hook format

Description of the change

Use the new Online Accounts API and hook format

Note that I've also added ubuntu-system-settings-online-accounts to the debian/control file as a dependency. In fact, even without these changes, that package was indeed needed if one wanted to create an Evernote account from inside the application. I'm not sure whether not listing it as a dependency was an omission or a deliberate choice (it might indeed be a deliberate choice, given that u-s-s-o-a is tricky to get to work on the unity7 dekstop and brings in a lot of unwanted packages like the Ubuntu Touch system settings) -- but with the new API, having that package is essential to get the Online Accounts functionality working at all.

Please let me know if the added dependency is acceptable; if it isn't, we might remove it along with the qml-module-ubuntu-onlineaccounts2 dependency and put all the Online Accounts functionality behind a Loader element, so that we disable the Evernote integration if the needed packages are not installed.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:496
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mardy/reminders-app/new-api/+merge/271505/+edit-commit-message

http://91.189.93.70:8080/job/reminders-app-ci/784/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/206/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/784/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks Michael for creating the MP. I didn't create it myself because this is still in a very early stage.
However, I'm happy to have some feedback on it, especially about the future of the .deb version. Do you intend to keep it?

The reason why I'm asking this, is because with the new Online Accounts hook, the .application, .service and .provider files are no longer necessary: they are automatically generated by the hook processor. However, if you want reminders-app to continue to live as a .deb as well, then we cannot remove these files (unless, maybe, we run the hook processor as part of the .deb build process -- sounds weird but it should work).

Reply
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:497
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mardy/reminders-app/new-api/+merge/271505/+edit-commit-message

http://91.189.93.70:8080/job/reminders-app-ci/785/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/207/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/785/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:498
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mardy/reminders-app/new-api/+merge/271505/+edit-commit-message

http://91.189.93.70:8080/job/reminders-app-ci/786/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/208/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/786/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:499
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mardy/reminders-app/new-api/+merge/271505/+edit-commit-message

http://91.189.93.70:8080/job/reminders-app-ci/791/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/213/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/791/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:500
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mardy/reminders-app/new-api/+merge/271505/+edit-commit-message

http://91.189.93.70:8080/job/reminders-app-ci/792/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/214/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/792/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:500
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mardy/reminders-app/new-api/+merge/271505/+edit-commit-message

https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/24/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/107/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/24/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Mardy: Is this still desired/required?

Reply
Revision history for this message
Alberto Mardegan (mardy) wrote :

> Mardy: Is this still desired/required?

Yes, but it cannot be merged yet, there are yet changes to be made on apparmor for this new API to work (bug #1512667).
Note that I didn't propose this MP myself. This MP should either be deleted or set to WIP.

Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:508
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/43/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/717/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/43/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
David Planella (dpm) wrote :

Bug #1512667 seems to have been fixed right now. Are we in a position to land this branch?

review: Needs Information
Reply
Revision history for this message
Alberto Mardegan (mardy) wrote :

Please read carefully this MP's description, as there's a problem with the deb version (I've tested the click and it seems to work fine).

Let me know how to proceed.

Reply

Unmerged revisions

508. By Alberto Mardegan

Update debian dependencies

507. By Alberto Mardegan

restore application file

506. By Alberto Mardegan

re-revert

505. By Alberto Mardegan

fix hook

504. By Alberto Mardegan

revert

503. By Alberto Mardegan

Fix service names

502. By Alberto Mardegan

Update plugin hook

501. By Alberto Mardegan

from trunk

500. By Alberto Mardegan

Set hostname as setting

499. By Alberto Mardegan

Accounts are always enabled

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches