Online Accounts: signond keyring extension

Merge lp://qastaging/~mardy/signon-keyring-extension/lp1172710 into lp://qastaging/signon-keyring-extension

  1. lp1172710
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Rejected
Rejected by: Ken VanDine
Proposed branch: lp://qastaging/~mardy/signon-keyring-extension/lp1172710
Merge into: lp://qastaging/signon-keyring-extension
Diff against target: 55 lines (+13/-2)
4 files modified
common-vars.pri (+1/-1)
debian/changelog (+8/-0)
debian/control (+1/-0)
src/secrets-storage.cpp (+3/-1)
To merge this branch: bzr merge lp://qastaging/~mardy/signon-keyring-extension/lp1172710
Reviewer Review Type Date Requested Status
Ken VanDine Disapprove
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+161097@code.qastaging.launchpad.net

Commit message

* Remove record when signond asks to remove the data for all authentication
  methods (LP: #1172710)
* Build with Qt5 by default

Description of the change

* Remove record when signond asks to remove the data for all authentication
  methods (LP: #1172710)
* Build with Qt5 by default

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:24
http://jenkins.qa.ubuntu.com/job/signon-keyring-extension-ci/5/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/signon-keyring-extension-raring-amd64-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/signon-keyring-extension-ci/5/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/signon-keyring-extension-autolanding/16/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/signon-keyring-extension-raring-amd64-autolanding/1/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/signon-keyring-extension-autolanding/17/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/signon-keyring-extension-raring-amd64-autolanding/2/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

This has lagged too long and now has conflicts. The autolanding failure was due to parts of the stack pulling in qt4 deps, which has since been resolved. I've cleaned up the conflicts and resubmitted at https://code.launchpad.net/~ken-vandine/signon-keyring-extension/0.5.1/+merge/167074

review: Disapprove

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches