Merge lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/2fa-1541274 into lp://qastaging/ubuntu-system-settings-online-accounts

Proposed by Alberto Mardegan
Status: Approved
Approved by: David Barth
Approved revision: 337
Proposed branch: lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/2fa-1541274
Merge into: lp://qastaging/ubuntu-system-settings-online-accounts
Diff against target: 310 lines (+132/-10)
3 files modified
online-accounts-ui/dialog-request.cpp (+33/-0)
online-accounts-ui/qml/SignOnUiDialog.qml (+56/-10)
tests/online-accounts-ui/qml/tst_SignOnUiDialog.qml (+43/-0)
To merge this branch: bzr merge lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/2fa-1541274
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Online Accounts Pending
Review via email: mp+287269@code.qastaging.launchpad.net

Commit message

Add 2fa support

Description of the change

Add 2fa support

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
333. By Alberto Mardegan

spacing

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
334. By Alberto Mardegan

Use email characters for username

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
335. By Alberto Mardegan

debugging

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
336. By Alberto Mardegan

Revert last change

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
337. By Alberto Mardegan

Dialog: use full width

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
338. By Alberto Mardegan

Update from trunk

[ Alberto Mardegan ]
* Fix false positive in duplicate account detection (LP: #1560494)
[ CI Train Bot ]
* Resync trunk.
[ Alberto Mardegan ]
* Bind flickable to page. (LP: #1544033)
* Don't crash on invalid providers (LP: #1554254)
* Don't use deprecated onLoadingChanged signal. (LP: #1544063)
* ProviderRequest: fix single account handling in authorization page
  (LP: #1552762)
* Update authorisation prompt (LP: #1544919)
[ CI Train Bot ]
* Resync trunk.
[ Alberto Mardegan ]
* Add check for duplicate account detection (LP: #1468599)
[ CI Train Bot ]
* Resync trunk.

339. By Alberto Mardegan

Merge from trunk

[ Alberto Mardegan ]
* Always show the UbuntuOne provider in the providers list (LP:
  #1559506)
* Enable scrolling in authorization page. (LP: #1561031)
[ CI Train Bot ]
* Resync trunk.

Unmerged revisions

339. By Alberto Mardegan

Merge from trunk

[ Alberto Mardegan ]
* Always show the UbuntuOne provider in the providers list (LP:
  #1559506)
* Enable scrolling in authorization page. (LP: #1561031)
[ CI Train Bot ]
* Resync trunk.

338. By Alberto Mardegan

Update from trunk

[ Alberto Mardegan ]
* Fix false positive in duplicate account detection (LP: #1560494)
[ CI Train Bot ]
* Resync trunk.
[ Alberto Mardegan ]
* Bind flickable to page. (LP: #1544033)
* Don't crash on invalid providers (LP: #1554254)
* Don't use deprecated onLoadingChanged signal. (LP: #1544063)
* ProviderRequest: fix single account handling in authorization page
  (LP: #1552762)
* Update authorisation prompt (LP: #1544919)
[ CI Train Bot ]
* Resync trunk.
[ Alberto Mardegan ]
* Add check for duplicate account detection (LP: #1468599)
[ CI Train Bot ]
* Resync trunk.

337. By Alberto Mardegan

Dialog: use full width

336. By Alberto Mardegan

Revert last change

335. By Alberto Mardegan

debugging

334. By Alberto Mardegan

Use email characters for username

333. By Alberto Mardegan

spacing

332. By Alberto Mardegan

Fix dbus keys

331. By Alberto Mardegan

Add test for error message

330. By Alberto Mardegan

Add tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches