Merge lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/apparmor-1489489 into lp://qastaging/ubuntu-system-settings-online-accounts

Proposed by Alberto Mardegan
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 387
Merged at revision: 397
Proposed branch: lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/apparmor-1489489
Merge into: lp://qastaging/ubuntu-system-settings-online-accounts
Diff against target: 82 lines (+20/-7)
4 files modified
online-accounts-service/online-accounts-service.pro (+1/-0)
online-accounts-service/utils.cpp (+17/-7)
tests/online-accounts-service/tst_service.pro (+1/-0)
tests/online-accounts-service/tst_signonui_service.pro (+1/-0)
To merge this branch: bzr merge lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/apparmor-1489489
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
Review via email: mp+306319@code.qastaging.launchpad.net

Commit message

Use GetConnectionCredentials() method instead of the deprecated apparmor-specific method.

Description of the change

Use GetConnectionCredentials() method instead of the deprecated apparmor-specific method.

To post a comment you must log in.
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

you dont need to update the debian/control?

review: Needs Information
387. By Alberto Mardegan

Address review comments

Revision history for this message
Alberto Mardegan (mardy) wrote :

No need to update debian/control, since we were already using libapparmor-dev. MP updated.

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches