Merge lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/dash-profile-1589444 into lp://qastaging/ubuntu-system-settings-online-accounts
Proposed by
Alberto Mardegan
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Paweł Stołowski | ||||
Approved revision: | 353 | ||||
Merged at revision: | 360 | ||||
Proposed branch: | lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/dash-profile-1589444 | ||||
Merge into: | lp://qastaging/ubuntu-system-settings-online-accounts | ||||
Diff against target: |
13 lines (+3/-0) 1 file modified
plugins/OnlineAccountsPlugin/application-manager.cpp (+3/-0) |
||||
To merge this branch: | bzr merge lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/dash-profile-1589444 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paweł Stołowski (community) | Approve | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email:
|
Commit message
Treat the Unity8 dash as an unconfined process
Description of the change
Treat the Unity8 dash as an unconfined process
To post a comment you must log in.
This fixes the basic auth problem, but I see something odd with youtube scope only with run with my confined dash changes - the scope thinks it's not authorized and keeps displaying the login button. The button however doesn't trigger OA backend afaict (there is no output from OAU_LOGGING_LEVEL=2 OAU_DAEMON_ TIMEOUT= 9999 online- accounts- service) , tapping it just re-executes the search.
Youtube scope executes the following code on every search to decide if "Log-in to youtube" button should be displayed:
for (auto const& status : oa_client_ ->get_service_ statuses( )) { service_ authenticated) {
config_ .authenticated = true;
config_ .access_ token = status. access_ token;
config_ .client_ id = status.client_id;
config_ .client_ secret = status. client_ secret;
break;
if (status.
}
}
if (!config_ .authenticated) {
std: :cerr << "YouTube scope is unauthenticated" << std::endl;
std: :cerr << "YouTube scope is authenticated" << std::endl;
} else {
}
And I can see "YouTube scope is unauthenticated" all the time even after I succesfully authenticated, that means status. service_ authenticated is false for all services.