Merge lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/dash-profile-1589444 into lp://qastaging/ubuntu-system-settings-online-accounts

Proposed by Alberto Mardegan
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 353
Merged at revision: 360
Proposed branch: lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/dash-profile-1589444
Merge into: lp://qastaging/ubuntu-system-settings-online-accounts
Diff against target: 13 lines (+3/-0)
1 file modified
plugins/OnlineAccountsPlugin/application-manager.cpp (+3/-0)
To merge this branch: bzr merge lp://qastaging/~mardy/ubuntu-system-settings-online-accounts/dash-profile-1589444
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+296533@code.qastaging.launchpad.net

Commit message

Treat the Unity8 dash as an unconfined process

Description of the change

Treat the Unity8 dash as an unconfined process

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

This fixes the basic auth problem, but I see something odd with youtube scope only with run with my confined dash changes - the scope thinks it's not authorized and keeps displaying the login button. The button however doesn't trigger OA backend afaict (there is no output from OAU_LOGGING_LEVEL=2 OAU_DAEMON_TIMEOUT=9999 online-accounts-service), tapping it just re-executes the search.

Youtube scope executes the following code on every search to decide if "Log-in to youtube" button should be displayed:

 for (auto const& status : oa_client_->get_service_statuses()) {
            if (status.service_authenticated) {
                config_.authenticated = true;
                config_.access_token = status.access_token;
                config_.client_id = status.client_id;
                config_.client_secret = status.client_secret;
                break;
            }
        }

        if (!config_.authenticated) {
            std::cerr << "YouTube scope is unauthenticated" << std::endl;
        } else {
            std::cerr << "YouTube scope is authenticated" << std::endl;
        }

And I can see "YouTube scope is unauthenticated" all the time even after I succesfully authenticated, that means status.service_authenticated is false for all services.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Yeah, works fine with the signon-apparmor-extension, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches