Merge lp://qastaging/~mardy/ubuntuone-credentials/fix-token-tests into lp://qastaging/ubuntuone-credentials
| Status: | Rejected |
|---|---|
| Rejected by: | Natalia Bidart |
| Proposed branch: | lp://qastaging/~mardy/ubuntuone-credentials/fix-token-tests |
| Merge into: | lp://qastaging/ubuntuone-credentials |
| Diff against target: |
72 lines (+9/-16) 2 files modified
libubuntuoneauth/tests/mock_sso_server.py.in (+1/-0) libubuntuoneauth/tests/test_token.cpp (+8/-16) |
| To merge this branch: | bzr merge lp://qastaging/~mardy/ubuntuone-credentials/fix-token-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| unity-api-1-bot | continuous-integration | Approve | |
| Unity API Team | Pending | ||
|
Review via email:
|
|||
Commit message
Tests: make sure the mock server is running before talking to it.
Intead of arbitrarily waiting 2 seconds for the mock server to be up, we make the server write a line to stdout, and we won't start the communication with it until we have received that line in the tests.
Also, terminate the server after the test, otherwise any instance started later will find the port busy.
Description of the change
Tests: make sure the mock server is running before talking to it.
Intead of arbitrarily waiting 2 seconds for the mock server to be up, we make the server write a line to stdout, and we won't start the communication with it until we have received that line in the tests.
Also, terminate the server after the test, otherwise any instance started later will find the port busy.
| unity-api-1-bot (unity-api-1-bot) wrote | # |
| Natalia Bidart (nataliabidart) wrote | # |
Unmerged revisions
- 248. By Alberto Mardegan
-
Tests: make sure the mock server is running before talking to it.
PASSED: Continuous integration, rev:248
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/