Merge lp://qastaging/~mardy/ubuntuone-credentials/loader-1620338 into lp://qastaging/ubuntuone-credentials
Proposed by
Alberto Mardegan
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | dobey | ||||
| Approved revision: | 251 | ||||
| Merged at revision: | 251 | ||||
| Proposed branch: | lp://qastaging/~mardy/ubuntuone-credentials/loader-1620338 | ||||
| Merge into: | lp://qastaging/ubuntuone-credentials | ||||
| Diff against target: |
13 lines (+1/-2) 1 file modified
online-accounts-provider/Main.qml (+1/-2) |
||||
| To merge this branch: | bzr merge lp://qastaging/~mardy/ubuntuone-credentials/loader-1620338 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Approve | ||
| unity-api-1-bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Fix the loader to avoid blank page with Qt 5.6.
Description of the change
Fix account plugin loading
Something must have changed within Loader in Qt 5.6, and the previous code was not working anymore.
To post a comment you must log in.
Revision history for this message
| unity-api-1-bot (unity-api-1-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:251
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/